Index: net/quic/quic_stream_sequencer_test.cc |
diff --git a/net/quic/quic_stream_sequencer_test.cc b/net/quic/quic_stream_sequencer_test.cc |
index a5ed9b2adff319058c1d7cc423390815429c75e6..33269cfb0e5284350d800b2a959067a3a56775c5 100644 |
--- a/net/quic/quic_stream_sequencer_test.cc |
+++ b/net/quic/quic_stream_sequencer_test.cc |
@@ -63,7 +63,8 @@ class QuicStreamSequencerTest : public ::testing::Test { |
session_(connection_), |
stream_(&session_, 1), |
sequencer_(new QuicStreamSequencer(&stream_)), |
- frames_(QuicStreamSequencerPeer::GetFrames(sequencer_.get())) { |
+ buffered_frames_( |
+ QuicStreamSequencerPeer::GetBufferedFrames(sequencer_.get())) { |
} |
bool VerifyReadableRegions(const char** expected, size_t num_expected) { |
@@ -126,38 +127,38 @@ class QuicStreamSequencerTest : public ::testing::Test { |
MockSession session_; |
testing::StrictMock<MockStream> stream_; |
scoped_ptr<QuicStreamSequencer> sequencer_; |
- map<QuicStreamOffset, string>* frames_; |
+ map<QuicStreamOffset, string>* buffered_frames_; |
}; |
TEST_F(QuicStreamSequencerTest, RejectOldFrame) { |
EXPECT_CALL(stream_, ProcessRawData(StrEq("abc"), 3)).WillOnce(Return(3)); |
EXPECT_TRUE(OnFrame(0, "abc")); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
EXPECT_EQ(3u, sequencer_->num_bytes_consumed()); |
// Ignore this - it matches a past sequence number and we should not see it |
// again. |
EXPECT_TRUE(OnFrame(0, "def")); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
} |
TEST_F(QuicStreamSequencerTest, RejectBufferedFrame) { |
EXPECT_CALL(stream_, ProcessRawData(StrEq("abc"), 3)); |
EXPECT_TRUE(OnFrame(0, "abc")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
// Ignore this - it matches a buffered frame. |
// Right now there's no checking that the payload is consistent. |
EXPECT_TRUE(OnFrame(0, "def")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
} |
TEST_F(QuicStreamSequencerTest, FullFrameConsumed) { |
EXPECT_CALL(stream_, ProcessRawData(StrEq("abc"), 3)).WillOnce(Return(3)); |
EXPECT_TRUE(OnFrame(0, "abc")); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
EXPECT_EQ(3u, sequencer_->num_bytes_consumed()); |
} |
@@ -165,12 +166,12 @@ TEST_F(QuicStreamSequencerTest, BlockedThenFullFrameConsumed) { |
sequencer_->SetBlockedUntilFlush(); |
EXPECT_TRUE(OnFrame(0, "abc")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
EXPECT_CALL(stream_, ProcessRawData(StrEq("abc"), 3)).WillOnce(Return(3)); |
sequencer_->FlushBufferedFrames(); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
EXPECT_EQ(3u, sequencer_->num_bytes_consumed()); |
EXPECT_CALL(stream_, ProcessRawData(StrEq("def"), 3)).WillOnce(Return(3)); |
@@ -182,13 +183,13 @@ TEST_F(QuicStreamSequencerTest, BlockedThenFullFrameAndFinConsumed) { |
sequencer_->SetBlockedUntilFlush(); |
EXPECT_TRUE(OnFinFrame(0, "abc")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
EXPECT_CALL(stream_, ProcessRawData(StrEq("abc"), 3)).WillOnce(Return(3)); |
EXPECT_CALL(stream_, OnFinRead()); |
sequencer_->FlushBufferedFrames(); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
EXPECT_EQ(3u, sequencer_->num_bytes_consumed()); |
} |
@@ -196,14 +197,14 @@ TEST_F(QuicStreamSequencerTest, EmptyFrame) { |
EXPECT_CALL(stream_, |
CloseConnectionWithDetails(QUIC_INVALID_STREAM_FRAME, _)); |
EXPECT_FALSE(OnFrame(0, "")); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
} |
TEST_F(QuicStreamSequencerTest, EmptyFinFrame) { |
EXPECT_CALL(stream_, OnFinRead()); |
EXPECT_TRUE(OnFinFrame(0, "")); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
} |
@@ -211,36 +212,36 @@ TEST_F(QuicStreamSequencerTest, PartialFrameConsumed) { |
EXPECT_CALL(stream_, ProcessRawData(StrEq("abc"), 3)).WillOnce(Return(2)); |
EXPECT_TRUE(OnFrame(0, "abc")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
EXPECT_EQ(2u, sequencer_->num_bytes_consumed()); |
- EXPECT_EQ("c", frames_->find(2)->second); |
+ EXPECT_EQ("c", buffered_frames_->find(2)->second); |
} |
TEST_F(QuicStreamSequencerTest, NextxFrameNotConsumed) { |
EXPECT_CALL(stream_, ProcessRawData(StrEq("abc"), 3)).WillOnce(Return(0)); |
EXPECT_TRUE(OnFrame(0, "abc")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
- EXPECT_EQ("abc", frames_->find(0)->second); |
+ EXPECT_EQ("abc", buffered_frames_->find(0)->second); |
} |
TEST_F(QuicStreamSequencerTest, FutureFrameNotProcessed) { |
EXPECT_TRUE(OnFrame(3, "abc")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
- EXPECT_EQ("abc", frames_->find(3)->second); |
+ EXPECT_EQ("abc", buffered_frames_->find(3)->second); |
} |
TEST_F(QuicStreamSequencerTest, OutOfOrderFrameProcessed) { |
// Buffer the first |
EXPECT_TRUE(OnFrame(6, "ghi")); |
- EXPECT_EQ(1u, frames_->size()); |
+ EXPECT_EQ(1u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
EXPECT_EQ(3u, sequencer_->num_bytes_buffered()); |
// Buffer the second |
EXPECT_TRUE(OnFrame(3, "def")); |
- EXPECT_EQ(2u, frames_->size()); |
+ EXPECT_EQ(2u, buffered_frames_->size()); |
EXPECT_EQ(0u, sequencer_->num_bytes_consumed()); |
EXPECT_EQ(6u, sequencer_->num_bytes_buffered()); |
@@ -254,7 +255,7 @@ TEST_F(QuicStreamSequencerTest, OutOfOrderFrameProcessed) { |
EXPECT_EQ(9u, sequencer_->num_bytes_consumed()); |
EXPECT_EQ(0u, sequencer_->num_bytes_buffered()); |
- EXPECT_EQ(0u, frames_->size()); |
+ EXPECT_EQ(0u, buffered_frames_->size()); |
} |
TEST_F(QuicStreamSequencerTest, BasicHalfCloseOrdered) { |