Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 329403002: Skip tests that has syntax errors in them (Closed)

Created:
6 years, 6 months ago by arv (Not doing code reviews)
Modified:
6 years, 6 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Skip tests that has syntax errors in them This is in preparation for a fix to V8 BUG=383596 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176055

Patch Set 1 #

Patch Set 2 : Use Failure instead of Skip #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
arv (Not doing code reviews)
6 years, 6 months ago (2014-06-11 22:31:00 UTC) #1
arv (Not doing code reviews)
PTAL
6 years, 6 months ago (2014-06-11 23:37:29 UTC) #2
esprehn
lgtm, how long until we can land the fix?
6 years, 6 months ago (2014-06-11 23:39:05 UTC) #3
arv (Not doing code reviews)
On 2014/06/11 23:39:05, esprehn wrote: > lgtm, how long until we can land the fix? ...
6 years, 6 months ago (2014-06-11 23:47:36 UTC) #4
ojan
Why skip instead of failure? Won't you need to rebaseline these once the fix is ...
6 years, 6 months ago (2014-06-12 03:52:38 UTC) #5
arv (Not doing code reviews)
On 2014/06/12 at 03:52:38, ojan wrote: > Why skip instead of failure? Won't you need ...
6 years, 6 months ago (2014-06-12 04:01:44 UTC) #6
arv (Not doing code reviews)
Use Failure instead of Skip
6 years, 6 months ago (2014-06-12 17:25:40 UTC) #7
arv (Not doing code reviews)
The CQ bit was checked by arv@chromium.org
6 years, 6 months ago (2014-06-12 18:56:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/329403002/20001
6 years, 6 months ago (2014-06-12 18:57:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 18:57:49 UTC) #10
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-12 18:57:50 UTC) #11
arv (Not doing code reviews)
merge
6 years, 6 months ago (2014-06-12 19:45:50 UTC) #12
arv (Not doing code reviews)
The CQ bit was checked by arv@chromium.org
6 years, 6 months ago (2014-06-12 19:46:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/329403002/40001
6 years, 6 months ago (2014-06-12 19:47:12 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:43:22 UTC) #15
Message was sent while issue was closed.
Change committed as 176055

Powered by Google App Engine
This is Rietveld 408576698