No longer relaunch into metro mode by default on touch devices.

No longer relaunch into metro mode by default on touch devices.

r232828 removed the touch device check in the delegate execute handler.
It should be removed from the "You're almost done" dialog and the
process singleton as well.

BUG=314818, 374360
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276853

[grt (UTC plus 2), 2014-06-12 15:10:29]

please review:

cpu: overall
gab: process singleton
sky: chrome OWNERS

thank you.

[sky, 2014-06-12 16:54:08]

LGTM

[cpu_(ooo_6.6-7.5), 2014-06-12 17:54:20]

looks good but I defer to zturner for final say.

[zturner, 2014-06-12 17:57:37]

On 2014/06/12 17:54:20, cpu wrote:
> looks good but I defer to zturner for final say.

lgtm

[gab, 2014-06-12 18:00:25]

Awesome, thanks for fixing this!

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/set_as_default_browser_ui.cc (left):

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/set_as_default_browser_ui.cc:395:
first_run::RemoveSentinel();
This was the last caller to first_run::RemoveSentinel(); please remove that
method as well.

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right):

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/set_as_default_browser_ui.cc:61:
MAKE_CHROME_DEFAULT_ACCEPTED_IMMERSE,  // OBSOLETE. Do not re-use.
Explicitly add a comment above stating that these values must not change as they
are used by a histogram.

Explicitly set the values in this enum and comment out the deprecated entry.

e.g.,
https://code.google.com/p/chromium/codesearch#chromium/src/base/prefs/persist...

https://codereview.chromium.org/329393004/diff/20001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (left):

https://codereview.chromium.org/329393004/diff/20001/chrome/common/pref_names...
chrome/common/pref_names.cc:1013:
"browser.suppress_switch_to_metro_mode_on_set_default";
Typically when phasing out prefs we still register them for some time followed
by a single ClearPref call to be removed after some time, e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pre...

In this case it's probably not even relevant to cleanup this pref for a
milestone or two as it was probably only used as a master pref and it's not like
cleaning it will drastically reduce the bloat in the pref file, WDYT?

[grt (UTC plus 2), 2014-06-12 18:29:15]

Thanks, Gab. PTAL.

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/set_as_default_browser_ui.cc (left):

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/set_as_default_browser_ui.cc:395:
first_run::RemoveSentinel();
On 2014/06/12 18:00:24, gab wrote:
> This was the last caller to first_run::RemoveSentinel(); please remove that
> method as well.

Wahoo!

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right):

https://codereview.chromium.org/329393004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/set_as_default_browser_ui.cc:61:
MAKE_CHROME_DEFAULT_ACCEPTED_IMMERSE,  // OBSOLETE. Do not re-use.
On 2014/06/12 18:00:24, gab wrote:
> Explicitly add a comment above stating that these values must not change as
they
> are used by a histogram.
> 
> Explicitly set the values in this enum and comment out the deprecated entry.
> 
> e.g.,
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/prefs/persist...

Done.

https://codereview.chromium.org/329393004/diff/20001/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (left):

https://codereview.chromium.org/329393004/diff/20001/chrome/common/pref_names...
chrome/common/pref_names.cc:1013:
"browser.suppress_switch_to_metro_mode_on_set_default";
On 2014/06/12 18:00:24, gab wrote:
> Typically when phasing out prefs we still register them for some time followed
> by a single ClearPref call to be removed after some time, e.g.
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pre...
> 
> In this case it's probably not even relevant to cleanup this pref for a
> milestone or two as it was probably only used as a master pref and it's not
like
> cleaning it will drastically reduce the bloat in the pref file, WDYT?

Thanks for bringing this up. As we discussed, we'll forget about it. The number
of installs with this setting is likely to be spectacularly small.

[gab, 2014-06-12 21:07:29]

lgtm, thanks!

[gab, 2014-06-12 21:07:34]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-06-12 21:09:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/grt@chromium.org/329393004/40001

[cpu_(ooo_6.6-7.5), 2014-06-12 22:39:40]

lgtm

[commit-bot: I haz the power, 2014-06-12 23:48:02]

Change committed as 276853