Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 329383006: Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator (Closed)

Created:
6 years, 6 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator. We have seen crashes which indicates that CoreAudioUtil::CreateDeviceEnumerator can in fact fail with CO_E_NOTINITIALIZED in combination with certain 3rd party modules. Calling CoInitializeEx is an attempt to resolve the reported issues. BUG=383715, 378465 TEST=WebRTC demos Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276721

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M media/audio/win/core_audio_util_win.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
henrika (OOO until Aug 14)
tommi@: as we discussed offline. Please take a look.
6 years, 6 months ago (2014-06-12 10:41:43 UTC) #1
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/329383006/diff/1/media/audio/win/core_audio_util_win.cc File media/audio/win/core_audio_util_win.cc (right): https://codereview.chromium.org/329383006/diff/1/media/audio/win/core_audio_util_win.cc#newcode249 media/audio/win/core_audio_util_win.cc:249: one line should be enough :)
6 years, 6 months ago (2014-06-12 10:56:20 UTC) #2
henrika (OOO until Aug 14)
Done. Thanks. https://codereview.chromium.org/329383006/diff/1/media/audio/win/core_audio_util_win.cc File media/audio/win/core_audio_util_win.cc (right): https://codereview.chromium.org/329383006/diff/1/media/audio/win/core_audio_util_win.cc#newcode249 media/audio/win/core_audio_util_win.cc:249: Ooops, sorry.
6 years, 6 months ago (2014-06-12 11:01:19 UTC) #3
henrika (OOO until Aug 14)
The CQ bit was checked by henrika@chromium.org
6 years, 6 months ago (2014-06-12 11:01:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/329383006/20001
6 years, 6 months ago (2014-06-12 11:07:47 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 17:12:25 UTC) #6
Message was sent while issue was closed.
Change committed as 276721

Powered by Google App Engine
This is Rietveld 408576698