net/base/sdch_manager.cc - Issue 329373002: Avoid advertising SDCH over HTTPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/sdch_manager.cc

Issue 329373002: Avoid advertising SDCH over HTTPS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reset global variables between tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/sdch_manager.cc

diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc

index 9e8fd98097865dc8ea08fcf99c69ad6975ec18b6..3b032bf7174474d944d146b9f9f312adfb3e79ce 100644

--- a/net/base/sdch_manager.cc

+++ b/net/base/sdch_manager.cc

@@ -333,6 +333,9 @@ bool SdchManager::IsInSupportedDomain(const GURL& url) {

if (!g_sdch_enabled_ )

return false;

+ if (!secure_scheme_supported() && url.SchemeIsSecure())

+ return false;

if (blacklisted_domains_.empty())

return true;

« no previous file with comments | « no previous file | net/base/sdch_manager_unittest.cc » ('j') | net/base/sdch_manager_unittest.cc » ('J')