Avoid advertising SDCH over HTTPS.

Avoid advertising SDCH over HTTPS.

BUG=383427
R=jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277366

[Randy Smith (Not in Mondays), 2014-06-11 21:28:59]

Jim: PTAL?  As noted in the bug, this is a proactive commit that isn't expected
to be needed, as we expect we'll be supporting HTTPS SDCH in the near time
frame.  But it was simple enough to throw together it seemed worthwhile
insurance against schedule slip around HTTPS :-}.

[jar (doing other things), 2014-06-12 15:28:13]

lgtm

[Randy Smith (Not in Mondays), 2014-06-12 18:17:33]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2014-06-12 18:21:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rdsmith@chromium.org/329373002/1

[commit-bot: I haz the power, 2014-06-12 23:02:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-06-13 00:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 00:40:20]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[mmenke, 2014-06-15 22:38:58]

Really should get rid of these globals at some point.

LGTM

https://codereview.chromium.org/329373002/diff/40001/net/base/sdch_manager_un...
File net/base/sdch_manager_unittest.cc (right):

https://codereview.chromium.org/329373002/diff/40001/net/base/sdch_manager_un...
net/base/sdch_manager_unittest.cc:33:
net::SdchManager::EnableSecureSchemeSupport(false);
nit:  net not needed.

https://codereview.chromium.org/329373002/diff/40001/net/base/sdch_manager_un...
net/base/sdch_manager_unittest.cc:180:
sdch_manager_->EnableSecureSchemeSupport(true);
Think it's clearer this is a static function if you call
"SdchManager::EnableSdchSupport"

[Randy Smith (Not in Mondays), 2014-06-15 23:37:17]

Thanks!

> Really should get rid of these globals at some point.

Fair.  I'll put it on my list.  They didn't belong in the per-profile DSes, so
they didn't get removed in that pass.

https://codereview.chromium.org/329373002/diff/40001/net/base/sdch_manager_un...
File net/base/sdch_manager_unittest.cc (right):

https://codereview.chromium.org/329373002/diff/40001/net/base/sdch_manager_un...
net/base/sdch_manager_unittest.cc:33:
net::SdchManager::EnableSecureSchemeSupport(false);
On 2014/06/15 22:38:58, mmenke wrote:
> nit:  net not needed.

Done.

https://codereview.chromium.org/329373002/diff/40001/net/base/sdch_manager_un...
net/base/sdch_manager_unittest.cc:180:
sdch_manager_->EnableSecureSchemeSupport(true);
On 2014/06/15 22:38:58, mmenke wrote:
> Think it's clearer this is a static function if you call
> "SdchManager::EnableSdchSupport"

Good point.  Done.

(Did both of these throughout the file.)

[Randy Smith (Not in Mondays), 2014-06-15 23:37:34]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2014-06-15 23:37:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rdsmith@chromium.org/329373002/80001

[commit-bot: I haz the power, 2014-06-16 07:13:27]

Change committed as 277366