Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: LayoutTests/http/tests/inspector/network-test.js

Issue 329323002: Deprecate support for xhr.withCredentials for synchronous requests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update per review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/inspector/network-test.js
diff --git a/LayoutTests/http/tests/inspector/network-test.js b/LayoutTests/http/tests/inspector/network-test.js
index 9657da07fe54ec83191198504b42f474815b0d08..ae59ab2a5bda9172a19f95760241f56249c2af10 100644
--- a/LayoutTests/http/tests/inspector/network-test.js
+++ b/LayoutTests/http/tests/inspector/network-test.js
@@ -91,7 +91,8 @@ function makeXHR(method, url, async, user, password, headers, withCredentials, p
}
}
xhr.open(method, url, async, user, password);
- xhr.withCredentials = withCredentials;
+ if (async)
tyoshino (SeeGerritForStatus) 2014/06/17 02:19:49 I think we should catch bad combination of argumen
tyoshino (SeeGerritForStatus) 2014/06/19 08:31:13 Reminder. (it's ok to skip it as it was drive-by c
+ xhr.withCredentials = withCredentials;
for (var i = 0; i < headers.length; ++i)
xhr.setRequestHeader(headers[i][0], headers[i][1]);
xhr.send(payload);

Powered by Google App Engine
This is Rietveld 408576698