LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html - Issue 329323002: Deprecate support for xhr.withCredentials for synchronous requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html

Issue 329323002: Deprecate support for xhr.withCredentials for synchronous requests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt ('k') | LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage-expected.txt » ('j') | Source/core/xml/XMLHttpRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html

diff --git a/LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html b/LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html

index 7e43c5388c765ee59b1a4dd9aba5f071a3e8beaf..57891aa344fceb6492b798c605069163ec3cb37c 100644

--- a/LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html

+++ b/LayoutTests/http/tests/xmlhttprequest/cross-origin-cookie-storage.html

@@ -100,7 +100,8 @@ function testSyncCookiesWithCredentials()

log("PASS: Finished sync xhr.");

var response = checkForCookie();

- log(response.match(/WK\-xhr\-cookie\-storage: MySpecialValue/) ? "PASS: Cookie set." : "FAIL: no cookie set.");

+ // As per issue #383483 xhr.withCredentials for synchronous requests is deprecated.

+ log(response.match(/WK\-xhr\-cookie\-storage: MySpecialValue/) ? "FAIL: Cookie set." : "PASS: no cookie set.");

log("DONE");

endTesting();

}