LayoutTests/http/tests/inspector/network-test.js - Issue 329323002: Deprecate support for xhr.withCredentials for synchronous requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/inspector/network-test.js

Issue 329323002: Deprecate support for xhr.withCredentials for synchronous requests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt ('k') | LayoutTests/http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt » ('j') | Source/core/xml/XMLHttpRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/inspector/network-test.js

diff --git a/LayoutTests/http/tests/inspector/network-test.js b/LayoutTests/http/tests/inspector/network-test.js

index 9657da07fe54ec83191198504b42f474815b0d08..ae59ab2a5bda9172a19f95760241f56249c2af10 100644

--- a/LayoutTests/http/tests/inspector/network-test.js

+++ b/LayoutTests/http/tests/inspector/network-test.js

@@ -91,7 +91,8 @@ function makeXHR(method, url, async, user, password, headers, withCredentials, p

}

xhr.open(method, url, async, user, password);

- xhr.withCredentials = withCredentials;

+ if (async)

+ xhr.withCredentials = withCredentials;

for (var i = 0; i < headers.length; ++i)

xhr.setRequestHeader(headers[i][0], headers[i][1]);

xhr.send(payload);