Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/core/xml/XMLHttpRequest.cpp

Issue 329323002: Deprecate support for xhr.withCredentials for synchronous requests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove async condition in network-test.js Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org> 3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org> 4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved. 5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved.
6 * Copyright (C) 2012 Intel Corporation 6 * Copyright (C) 2012 Intel Corporation
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 } 480 }
481 } 481 }
482 482
483 void XMLHttpRequest::setWithCredentials(bool value, ExceptionState& exceptionSta te) 483 void XMLHttpRequest::setWithCredentials(bool value, ExceptionState& exceptionSta te)
484 { 484 {
485 if (m_state > OPENED || m_loader) { 485 if (m_state > OPENED || m_loader) {
486 exceptionState.throwDOMException(InvalidStateError, "The value may only be set if the object's state is UNSENT or OPENED."); 486 exceptionState.throwDOMException(InvalidStateError, "The value may only be set if the object's state is UNSENT or OPENED.");
487 return; 487 return;
488 } 488 }
489 489
490 // FIXME: According to XMLHttpRequest Level 2 we should throw InvalidAccessE rror exception here.
491 // However for time being only print warning message to warn web developers.
492 if (!m_async)
493 UseCounter::countDeprecation(executionContext(), UseCounter::SyncXHRWith Credentials);
494
490 m_includeCredentials = value; 495 m_includeCredentials = value;
491 } 496 }
492 497
493 bool XMLHttpRequest::isAllowedHTTPMethod(const String& method) 498 bool XMLHttpRequest::isAllowedHTTPMethod(const String& method)
494 { 499 {
495 return !equalIgnoringCase(method, "TRACE") 500 return !equalIgnoringCase(method, "TRACE")
496 && !equalIgnoringCase(method, "TRACK") 501 && !equalIgnoringCase(method, "TRACK")
497 && !equalIgnoringCase(method, "CONNECT"); 502 && !equalIgnoringCase(method, "CONNECT");
498 } 503 }
499 504
(...skipping 965 matching lines...) Expand 10 before | Expand all | Expand 10 after
1465 { 1470 {
1466 visitor->trace(m_responseBlob); 1471 visitor->trace(m_responseBlob);
1467 visitor->trace(m_responseStream); 1472 visitor->trace(m_responseStream);
1468 visitor->trace(m_responseDocument); 1473 visitor->trace(m_responseDocument);
1469 visitor->trace(m_progressEventThrottle); 1474 visitor->trace(m_progressEventThrottle);
1470 visitor->trace(m_upload); 1475 visitor->trace(m_upload);
1471 XMLHttpRequestEventTarget::trace(visitor); 1476 XMLHttpRequestEventTarget::trace(visitor);
1472 } 1477 }
1473 1478
1474 } // namespace WebCore 1479 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698