Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 329303009: Cleanup [RuntimeEnabled] use in Window (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, watchdog-blink-watchlist_google.com, blink-reviews-bindings_chromium.org, arv+blink, Inactive, abarth-chromium, ajuma, Jens Widell
Project:
blink
Visibility:
Public.

Description

Cleanup [RuntimeEnabled] use in Window This removes some cruft added in: Bindings for CSSOM View smooth scroll API https://codereview.chromium.org/146003002 ...which was done b/c [RuntimeEnabled] didn't work properly on overloaded methods. This has been fixed (thanks Jens!) and thus the cruft can be removed. R=haraken BUG=339000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176088

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -21 lines) Patch
M Source/bindings/scripts/v8_utilities.py View 2 chunks +12 lines, -3 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 3 chunks +15 lines, -7 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
decruft, decruft https://codereview.chromium.org/329303009/diff/1/Source/bindings/scripts/v8_utilities.py File Source/bindings/scripts/v8_utilities.py (left): https://codereview.chromium.org/329303009/diff/1/Source/bindings/scripts/v8_utilities.py#oldcode36 Source/bindings/scripts/v8_utilities.py:36: # FIXME: eliminate this file if possible ...
6 years, 6 months ago (2014-06-13 03:19:56 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-13 03:27:01 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-13 04:05:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/329303009/20001
6 years, 6 months ago (2014-06-13 04:06:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 05:09:59 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 05:45:28 UTC) #6
Message was sent while issue was closed.
Change committed as 176088

Powered by Google App Engine
This is Rietveld 408576698