Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/content_hash_fetcher.h

Issue 329303007: Fix several problems with the content verification code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ready Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/content_hash_fetcher.h
diff --git a/extensions/browser/content_hash_fetcher.h b/extensions/browser/content_hash_fetcher.h
index d437d8f10949a9098777f663015d65db11d9d35a..55c845f8e7df64562445f7d72c61b9b32d878755 100644
--- a/extensions/browser/content_hash_fetcher.h
+++ b/extensions/browser/content_hash_fetcher.h
@@ -5,6 +5,11 @@
#ifndef EXTENSIONS_BROWSER_CONTENT_HASH_FETCHER_H_
#define EXTENSIONS_BROWSER_CONTENT_HASH_FETCHER_H_
+#include <set>
+#include <string>
+
+#include "base/callback.h"
+#include "base/files/file_path.h"
#include "base/memory/weak_ptr.h"
#include "base/scoped_observer.h"
#include "extensions/browser/content_verifier_delegate.h"
@@ -28,18 +33,31 @@ class ContentHashFetcherJob;
// sure they match the signed treehash root hash).
class ContentHashFetcher : public ExtensionRegistryObserver {
public:
+ // A callback for when a fetch is complete. This reports back:
+ // -extension id
+ // -whether we were successful or not (have verified_contents.json and
+ // -computed_hashes.json files)
+ // -was it a forced check?
+ // -a set of paths whose contents didn't match expected values
+ typedef base::Callback<
+ void(const std::string&, bool, bool, const std::set<base::FilePath>&)>
+ FetchCallback;
+
// The consumer of this class needs to ensure that context and delegate
// outlive this object.
ContentHashFetcher(content::BrowserContext* context,
- ContentVerifierDelegate* delegate);
+ ContentVerifierDelegate* delegate,
+ const FetchCallback& callback);
virtual ~ContentHashFetcher();
// Begins the process of trying to fetch any needed verified contents, and
// listening for extension load/unload.
void Start();
- // Explicitly ask to fetch hashes for |extension|.
- void DoFetch(const Extension* extension);
+ // Explicitly ask to fetch hashes for |extension|. If |force| is true,
+ // we will always check the validity of the verified_contents.json and
+ // re-check the contents of the files in the filesystem.
+ void DoFetch(const Extension* extension, bool force);
// ExtensionRegistryObserver interface
virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
@@ -55,6 +73,7 @@ class ContentHashFetcher : public ExtensionRegistryObserver {
content::BrowserContext* context_;
ContentVerifierDelegate* delegate_;
+ FetchCallback fetch_callback_;
// We keep around pointers to in-progress jobs, both so we can avoid
// scheduling duplicate work if fetching is already in progress, and so that
« no previous file with comments | « no previous file | extensions/browser/content_hash_fetcher.cc » ('j') | extensions/browser/content_hash_fetcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698