Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329293002: Revert "Revert 3 mac autofill CLs." (Closed)

Created:
6 years, 6 months ago by erikchen
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tim+watch_chromium.org, jam, asvitkine+watch_chromium.org, benquan, browser-components-watch_chromium.org, haitaol+watch_chromium.org, jar+watch_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, dyu1, estade+watch_chromium.org, maniscalco+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, Dane Wallinga
Visibility:
Public.

Description

Revert "Revert 3 mac autofill CLs." The reverted CLs are no longer suspected of causing a renderer crash. https://code.google.com/p/chromium/issues/detail?id=382144 This reverts commit dbf46869b07c09eb74515ba2c8e9a727b0a09c65. TBR=isherman@chromium.org BUG=382144 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -80 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/autofill_options.js View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm View 7 chunks +116 lines, -33 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M components/autofill.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M components/autofill/content/common/autofill_messages.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_driver.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 8 chunks +95 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 2 chunks +17 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 3 chunks +66 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +12 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_mac.mm View 4 chunks +76 lines, -14 lines 0 comments Download
M components/autofill/core/browser/popup_item_ids.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_driver.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/test_autofill_driver.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/core/common/autofill_pref_names.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/common/autofill_pref_names.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M components/autofill_strings.grdp View 1 chunk +7 lines, -0 lines 0 comments Download
M components/resources/autofill_scaled_resources.grdp View 1 chunk +1 line, -0 lines 0 comments Download
A components/resources/default_100_percent/common/autofill/mac_contacts_icon.png View Binary file 0 comments Download
A components/resources/default_200_percent/common/autofill/mac_contacts_icon.png View Binary file 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 6 months ago (2014-06-11 17:43:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/329293002/1
6 years, 6 months ago (2014-06-11 17:46:09 UTC) #2
erikchen
The CQ bit was unchecked by erikchen@chromium.org
6 years, 6 months ago (2014-06-11 17:53:36 UTC) #3
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 6 months ago (2014-06-11 17:54:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/329293002/1
6 years, 6 months ago (2014-06-11 17:54:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:18:14 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:21:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15648)
6 years, 6 months ago (2014-06-11 21:21:47 UTC) #8
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 6 months ago (2014-06-11 21:22:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/329293002/1
6 years, 6 months ago (2014-06-11 21:25:42 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:49:50 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:52:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21887) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19701) mac_gpu ...
6 years, 6 months ago (2014-06-11 21:52:14 UTC) #13
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 6 months ago (2014-06-12 01:40:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/329293002/1
6 years, 6 months ago (2014-06-12 01:43:17 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 07:45:43 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:49:20 UTC) #17
Message was sent while issue was closed. 
Change committed as 276643

Powered by Google App Engine
This is Rietveld 408576698