Optimize Map/Set.prototype.forEach

src/runtime.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 #include <limits>
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
@@ skipping 1592 matching lines @@
 
 
 RUNTIME_FUNCTION(Runtime_SetIteratorNext) {
   HandleScope scope(isolate);
   ASSERT(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(JSSetIterator, holder, 0);
   return *JSSetIterator::Next(holder);
 }
 
 
+RUNTIME_FUNCTION(Runtime_SetIteratorCurrentKey) {
+  SealHandleScope shs(isolate);
+  ASSERT(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSSetIterator, holder, 0);

[adamk, 2014/06/16 22:13:57]

This should just be CONVERT_ARG_CHECKED() (no "HANDLE") now.

+  return holder->CurrentKey();
+}
+
+
+RUNTIME_FUNCTION(Runtime_SetIteratorHasMore) {
+  HandleScope scope(isolate);
+  ASSERT(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSSetIterator, holder, 0);
+  return isolate->heap()->ToBoolean(JSSetIterator::HasMore(holder));
+}
+
+
+RUNTIME_FUNCTION(Runtime_SetIteratorMoveNext) {
+  SealHandleScope shs(isolate);
+  ASSERT(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSSetIterator, holder, 0);
+  holder->MoveNext();
+  return isolate->heap()->undefined_value();
+}
+
+
 RUNTIME_FUNCTION(Runtime_MapInitialize) {
   HandleScope scope(isolate);
   ASSERT(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(JSMap, holder, 0);
   Handle<OrderedHashMap> table = isolate->factory()->NewOrderedHashMap();
   holder->set_table(*table);
   return *holder;
 }
 
 
@@ skipping 84 matching lines @@
 
 
 RUNTIME_FUNCTION(Runtime_MapIteratorNext) {
   HandleScope scope(isolate);
   ASSERT(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED(JSMapIterator, holder, 0);
   return *JSMapIterator::Next(holder);
 }
 
 
+RUNTIME_FUNCTION(Runtime_MapIteratorCurrentKey) {
+  SealHandleScope shs(isolate);
+  ASSERT(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSMapIterator, holder, 0);

[adamk, 2014/06/16 22:13:57]

ditto, and lots more below.

Basically, SealHandleScope should be paired with CONVERT_ARG_CHECKED(), while
HandleScope should be paired with CONVERT_ARG_HANDLE_CHECKED(). Similarly, if
your Runtime function uses Handles at all, it should have a HandleScope, not a
SealHandleScope.

V8 folks, please correct me if I'm providing poor advice here. My understanding
is that V8's not abandoning raw pointers altogether, only in those cases that
previously required MaybeObjects.

+  return holder->CurrentKey();
+}
+
+
+RUNTIME_FUNCTION(Runtime_MapIteratorCurrentValue) {
+  SealHandleScope shs(isolate);
+  ASSERT(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSMapIterator, holder, 0);
+  return holder->CurrentValue();
+}
+
+
+RUNTIME_FUNCTION(Runtime_MapIteratorHasMore) {
+  HandleScope scope(isolate);
+  ASSERT(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSMapIterator, holder, 0);
+  return isolate->heap()->ToBoolean(JSMapIterator::HasMore(holder));
+}
+
+
+RUNTIME_FUNCTION(Runtime_MapIteratorMoveNext) {
+  SealHandleScope shs(isolate);
+  ASSERT(args.length() == 1);
+  CONVERT_ARG_HANDLE_CHECKED(JSMapIterator, holder, 0);
+  holder->MoveNext();
+  return isolate->heap()->undefined_value();
+}
+
+
 static Handle<JSWeakCollection> WeakCollectionInitialize(
     Isolate* isolate,
     Handle<JSWeakCollection> weak_collection) {
   ASSERT(weak_collection->map()->inobject_properties() == 0);
   Handle<ObjectHashTable> table = ObjectHashTable::New(isolate, 0);
   weak_collection->set_table(*table);
   return weak_collection;
 }
 
 
@@ skipping 13417 matching lines @@
   }
   return NULL;
 }
 
 
 const Runtime::Function* Runtime::FunctionForId(Runtime::FunctionId id) {
   return &(kIntrinsicFunctions[static_cast<int>(id)]);
 }
 
 } }  // namespace v8::internal