Issue 329253003: Revert 21774: "Generate KeyedLoadGeneric with Hydrogen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329253003: Revert 21774: "Generate KeyedLoadGeneric with Hydrogen" (Closed)

Created:
6 years, 6 months ago by danno

Modified:
6 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert 21774: "Generate KeyedLoadGeneric with Hydrogen" Due to arm64 and GCMole failures TBR=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21776

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -799 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/code-stubs.h	View	2 chunks	+0 lines, -24 lines	0 comments	Download
M	src/code-stubs.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	2 chunks	+1 line, -305 lines	0 comments	Download
M	src/elements-kind.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/field-index.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/field-index-inl.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/hydrogen.h	View	3 chunks	+1 line, -56 lines	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+5 lines, -201 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	4 chunks	+3 lines, -48 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/ic.h	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/ic.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects.h	View	2 chunks	+3 lines, -38 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+10 lines, -11 lines	0 comments	Download
M	src/serialize.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	test/mjsunit/keyed-load-dictionary-stub.js	View	1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

Committed patchset #1 manually as r21776 (tree was closed).

6 years, 6 months ago (2014-06-11 16:34:33 UTC) #2

Message was sent while issue was closed.

LGTM (rubber-stamped).

Expand Messages | Collapse Messages