apps/app_shim/chrome_main_app_mode_mac.mm - Issue 329253002: Revert of [Mac] Add interactive App Shim test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/app_shim/chrome_main_app_mode_mac.mm

Issue 329253002: Revert of [Mac] Add interactive App Shim test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: apps/app_shim/chrome_main_app_mode_mac.mm

diff --git a/apps/app_shim/chrome_main_app_mode_mac.mm b/apps/app_shim/chrome_main_app_mode_mac.mm

index e887e59cb561f503759d2f222ba37a3dbcbec583..1092142733bf4aad26df875b30ec7e34c419160d 100644

--- a/apps/app_shim/chrome_main_app_mode_mac.mm

+++ b/apps/app_shim/chrome_main_app_mode_mac.mm

@@ -611,11 +611,7 @@

main_message_loop.set_thread_name("MainThread");

base::PlatformThread::SetName("CrAppShimMain");

- // In tests, launching Chrome does nothing, and we won't get a ping response,

- // so just assume the socket exists.

- if (pid == -1 &&

- !CommandLine::ForCurrentProcess()->HasSwitch(

- app_mode::kLaunchedForTest)) {

+ if (pid == -1) {

// Launch Chrome if it isn't already running.

ProcessSerialNumber psn;

CommandLine command_line(CommandLine::NO_PROGRAM);