Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 329233002: [Arm]: Make Assembler::movw only emit a movw instruction. (Closed)

Created:
6 years, 6 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

[Arm]: Make Assembler::movw only emit a movw instruction. Currently Assembler::movw is really the mov macro instruction, leading to raw emit calls to generate the real movw instruction. Replace all calls of mow with the mov macro instruction (which will emit a movw if appropriate) and make movw always emit movw. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Ulan, please take a look, thanks.
6 years, 5 months ago (2014-06-30 09:38:26 UTC) #1
ulan
lgtm
6 years, 5 months ago (2014-06-30 10:07:09 UTC) #2
rmcilroy
6 years, 5 months ago (2014-06-30 11:07:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22085 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698