Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 329223006: MIPS: Fix unsigned comparison. (Closed)

Created:
6 years, 6 months ago by kilvadyb
Modified:
6 years, 6 months ago
Reviewers:
kisg, Paul Lind, palfia, danno, dusmil
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Fix unsigned comparison. TEST=mjsunit/regress/regress-3380 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
bgtz does a signed comparison: "If the contents of GPR rs are greater than zero ...
6 years, 6 months ago (2014-06-12 15:18:58 UTC) #1
Paul Lind
lgtm
6 years, 6 months ago (2014-06-12 15:39:06 UTC) #2
Paul Lind
6 years, 6 months ago (2014-06-12 15:42:43 UTC) #3
Committed as r21815.

Powered by Google App Engine
This is Rietveld 408576698