Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: Source/core/events/EventTarget.h

Issue 329223004: [DeprecateAs] if call addEventListener or removeEventListener without enough arguments Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix template condition Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/core/events/EventTarget.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.h
diff --git a/Source/core/events/EventTarget.h b/Source/core/events/EventTarget.h
index 2e86b3c77db0cb44c1142814ad9ff84bbdf0ef81..790e68098b2c44cf5ae1d3af72d54b6795149654 100644
--- a/Source/core/events/EventTarget.h
+++ b/Source/core/events/EventTarget.h
@@ -89,6 +89,8 @@ public:
// FIXME: first 2 args to addEventListener and removeEventListener should
// be required (per spec), but throwing TypeError breaks legacy content.
// http://crbug.com/353484
+ // FIXME: default values should be specified in IDL, not C++
+ // http://crbug.com/258153
bool addEventListener() { return false; }
bool addEventListener(const AtomicString& eventType) { return false; }
virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture = false);
« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/core/events/EventTarget.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698