Issue 3292019: Printing: Convert several wstrings to string16.

Issue 3292019: Printing: Convert several wstrings to string16. (Closed)

Created:
10 years, 3 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, viettrungluu

CC:
chromium-reviews, ben+cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Printing: Convert several wstrings to string16. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59262

Patch Set 7 : Review fixes. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -55 lines)			Patch
M	chrome/browser/browser_main.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_job_unittest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.h	View	1 2 3 4 5 6	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	printing/page_overlays.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -3 lines	0 comments	Download
M	printing/page_overlays_unittest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	printing/printed_document.h	View	1 2 3	3 chunks	+10 lines, -8 lines	0 comments	Download
M	printing/printed_document.cc	View	1 2 3 4 5	4 chunks	+18 lines, -23 lines	0 comments	Download
M	printing/printed_pages_source.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	printing/printing_context.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	printing/printing_context_cairo.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_mac.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	printing/printing_context_win.cc	View	1 2 3 4 5 6	4 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

Alright, all compile issues fixed. Should actually be good for review now.

10 years, 3 months ago (2010-09-11 23:17:54 UTC) #2

viettrungluu

LGTM with a few nits. http://codereview.chromium.org/3292019/diff/10001/11004 File chrome/browser/printing/print_view_manager.h (right): http://codereview.chromium.org/3292019/diff/10001/11004#newcode9 chrome/browser/printing/print_view_manager.h:9: #include "base/ref_counted.h" Should probably ...

10 years, 3 months ago (2010-09-13 16:29:46 UTC) #3

James Hawkins

10 years, 3 months ago (2010-09-13 17:34:11 UTC) #5

http://codereview.chromium.org/3292019/diff/10001/11004
File chrome/browser/printing/print_view_manager.h (right):

http://codereview.chromium.org/3292019/diff/10001/11004#newcode9
chrome/browser/printing/print_view_manager.h:9: #include "base/ref_counted.h"
On 2010/09/13 16:29:47, viettrungluu wrote:
> Should probably #include "base/string16.h".

Done.

http://codereview.chromium.org/3292019/diff/10001/11005
File printing/page_overlays.cc (right):

http://codereview.chromium.org/3292019/diff/10001/11005#newcode152
printing/page_overlays.cc:152: UTF16ToWide(document.name()));
On 2010/09/13 16:29:47, viettrungluu wrote:
> These should probably be UTF16ToWideHack()s, since the code should presumably
be
> changed to use string16s.

Ah yes, forgot to append the Hack.

http://codereview.chromium.org/3292019/diff/10001/11013
File printing/printing_context_win.cc (right):

http://codereview.chromium.org/3292019/diff/10001/11013#newcode265
printing/printing_context_win.cc:265: di.lpszDocName =
UTF16ToWideHack(document_name).c_str();
On 2010/09/13 16:29:47, viettrungluu wrote:
> If it's going into a Windows-specific struct, then probably we don't need the
> "Hack".

Done.

http://codereview.chromium.org/3292019/diff/10001/11013#newcode277
printing/printing_context_win.cc:277: filename +=
UTF16ToWideHack(document_name);
On 2010/09/13 16:29:47, viettrungluu wrote:
> Ditto (since these are Windows-specific filenames).

Done.

Expand Messages | Collapse Messages