sign_official_build.sh: If found, sign the packaged firmware autoupdate.

If found, sign the packaged firmware autoupdate.

Previously this was hidden behind an environment variable. With this change, the signing script will always try to sign the firmware update if found. If not, it will still perform the remaining steps (rootfs calculation, kernel partition signature etc.).

Also fixed a few minor bugs with the firmware update code.

BUG=chrome-os-partner:925, chrome-os:3496
TEST=created a ToT semi-official build, and ran the signing script on the image. Verified that the firmware got correctly updated (by running chromeos-firmwareupdate on the device). Also tested on images without the packaged firmware update.

Change-Id: I0921ce36a880e18167a8e3a2b63d8f246693d488

[Hung-Te, 2010-09-10 04:00:36]

http://codereview.chromium.org/3292016/diff/1/2
File scripts/image_signing/sign_official_build.sh (right):

http://codereview.chromium.org/3292016/diff/1/2#newcode166
scripts/image_signing/sign_official_build.sh:166: { echo "Extracting firmware
autoupdate failed." && return 1; }
Usually the input is supposed to be a valid input zero bytes (for a image not
carrying firmware). We should consider a non-zero file with invalid content as
real error.

I think you can do 
if [ -s $input ]; then
  uudecode ... && exit 1
else
  return 1
fi

[gauravsh, 2010-09-10 04:12:36]

On 2010/09/10 04:00:36, Hung-Te wrote:
> http://codereview.chromium.org/3292016/diff/1/2
> File scripts/image_signing/sign_official_build.sh (right):
> 
> http://codereview.chromium.org/3292016/diff/1/2#newcode166
> scripts/image_signing/sign_official_build.sh:166: { echo "Extracting firmware
> autoupdate failed." && return 1; }
> Usually the input is supposed to be a valid input zero bytes (for a image not
> carrying firmware). We should consider a non-zero file with invalid content as
> real error.
> 
> I think you can do 
> if [ -s $input ]; then
>   uudecode ... && exit 1
> else
>   return 1
> fi

Good point. Done.

[Hung-Te, 2010-09-10 04:16:48]

LGTM