Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4112)

Unified Diff: chrome/browser/prefs/pref_hash_filter_unittest.cc

Issue 329173002: Make a JsonPrefStore readable while mid-interception. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_hash_filter_unittest.cc
diff --git a/chrome/browser/prefs/pref_hash_filter_unittest.cc b/chrome/browser/prefs/pref_hash_filter_unittest.cc
index ea63a88ee718d0b2e9757ad6ab334af7cb305ede..e200d2f5bd3f6238b66e2195b486760a31564bd6 100644
--- a/chrome/browser/prefs/pref_hash_filter_unittest.cc
+++ b/chrome/browser/prefs/pref_hash_filter_unittest.cc
@@ -358,7 +358,7 @@ class PrefHashFilterTest
pref_hash_filter_->FilterOnLoad(
base::Bind(&PrefHashFilterTest::GetPrefsBack, base::Unretained(this),
expect_prefs_modifications),
- pref_store_contents_.Pass());
+ pref_store_contents_.get());
}
MockPrefHashStore* mock_pref_hash_store_;
@@ -368,13 +368,9 @@ class PrefHashFilterTest
scoped_ptr<PrefHashFilter> pref_hash_filter_;
private:
- // Stores |prefs| back in |pref_store_contents| and ensure
- // |expected_schedule_write| matches the reported |schedule_write|.
+ // Ensures |expected_schedule_write| matches the reported |schedule_write|.
void GetPrefsBack(bool expected_schedule_write,
gab 2014/06/11 21:12:55 The name of this method doesn't make sense anymore
- scoped_ptr<base::DictionaryValue> prefs,
bool schedule_write) {
- pref_store_contents_ = prefs.Pass();
- EXPECT_TRUE(pref_store_contents_);
EXPECT_EQ(expected_schedule_write, schedule_write);
}

Powered by Google App Engine
This is Rietveld 408576698