Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 329143004: Skip WPR archives when use-live-sites is set. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
dtu, bolian, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Skip WPR archives when use-live-sites is set. Make page_runner more tolerant to cloudStorageError (crbug.com/369611). BUG=368061 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276568

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Address Bolian's comment (renaming) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 2 chunks +8 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + tools/telemetry/unittest_data/data/archive_blank.json View 1 chunk +3 lines, -3 lines 0 comments Download
A tools/telemetry/unittest_data/data/archive_blank_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-11 16:02:59 UTC) #1
bolian
lgtm https://codereview.chromium.org/329143004/diff/20001/tools/telemetry/telemetry/page/page_runner_unittest.py File tools/telemetry/telemetry/page/page_runner_unittest.py (right): https://codereview.chromium.org/329143004/diff/20001/tools/telemetry/telemetry/page/page_runner_unittest.py#newcode517 tools/telemetry/telemetry/page/page_runner_unittest.py:517: self.TestUseLiveSitesFlag(options, expected_is_page_from_archive=False) s/expected_is_page_from_archive/expect_from_archive ?
6 years, 6 months ago (2014-06-11 20:59:22 UTC) #2
nednguyen
On 2014/06/11 20:59:22, bolian wrote: > lgtm > > https://codereview.chromium.org/329143004/diff/20001/tools/telemetry/telemetry/page/page_runner_unittest.py > File tools/telemetry/telemetry/page/page_runner_unittest.py (right): > ...
6 years, 6 months ago (2014-06-11 22:24:13 UTC) #3
tonyg
lgtm
6 years, 6 months ago (2014-06-11 22:34:41 UTC) #4
tonyg
The CQ bit was unchecked by tonyg@chromium.org
6 years, 6 months ago (2014-06-11 22:34:45 UTC) #5
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-11 22:35:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/329143004/40001
6 years, 6 months ago (2014-06-11 22:37:21 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:55:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:07:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160461) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149869)
6 years, 6 months ago (2014-06-12 00:07:16 UTC) #10
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-12 03:35:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/329143004/40001
6 years, 6 months ago (2014-06-12 03:36:38 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 07:46:44 UTC) #13
Message was sent while issue was closed.
Change committed as 276568

Powered by Google App Engine
This is Rietveld 408576698