Compile fix for OpenSSL on Mac and Windows

net/socket/ssl_server_socket_openssl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_server_socket_openssl.h"
 
 #include <openssl/err.h>
 #include <openssl/ssl.h>
 
 #include "base/callback_helpers.h"
@@ skipping 598 matching lines @@
   // 0 => use default buffer sizes.
   if (!BIO_new_bio_pair(&ssl_bio, 0, &transport_bio_, 0))
     return ERR_UNEXPECTED;
   DCHECK(ssl_bio);
   DCHECK(transport_bio_);
 
   SSL_set_bio(ssl_, ssl_bio, ssl_bio);
 
   // Set certificate and private key.
   DCHECK(cert_->os_cert_handle());
+#if defined(USE_OPENSSL_CERTS)
   if (SSL_use_certificate(ssl_, cert_->os_cert_handle()) != 1) {
     LOG(ERROR) << "Cannot set certificate.";
     return ERR_UNEXPECTED;
   }
+#else
+  // Convert OSCertHandle to X509 structure.
+  std::string der_string;
+  if (!X509Certificate::GetDEREncoded(cert_->os_cert_handle(), &der_string))
+    return ERR_UNEXPECTED;
+
+  const unsigned char* der_string_array =
+      reinterpret_cast<const unsigned char*>(der_string.data());
+
+  crypto::ScopedOpenSSL<X509, X509_free>
+    x509(d2i_X509(NULL, &der_string_array, der_string.length()));

[wtc, 2014/06/11 23:44:05]

This line should be indented with four spaces.

+  if (!x509.get())
+    return ERR_UNEXPECTED;
+
+  // On success, SSL_use_certificate counts up the reference count on cert.

[wtc, 2014/06/11 23:44:05]

1. Nit: cert => |x509|

2. Nit: counts up => increments

Or we can say "acquires a reference to |x509|".

+  if (SSL_use_certificate(ssl_, x509.get()) != 1) {
+    LOG(ERROR) << "Cannot set certificate.";
+    return ERR_UNEXPECTED;
+  }
+#endif  // USE_OPENSSL_CERTS
 
   DCHECK(key_->key());
   if (SSL_use_PrivateKey(ssl_, key_->key()) != 1) {
     LOG(ERROR) << "Cannot set private key.";
     return ERR_UNEXPECTED;
   }
 
   // OpenSSL defaults some options to on, others to off. To avoid ambiguity,
   // set everything we care about to an absolute value.
   SslSetClearMask options;
@@ skipping 22 matching lines @@
 
   mode.ConfigureFlag(SSL_MODE_RELEASE_BUFFERS, true);
 
   SSL_set_mode(ssl_, mode.set_mask);
   SSL_clear_mode(ssl_, mode.clear_mask);
 
   return OK;
 }
 
 }  // namespace net