Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 329113002: DevTools: Restore toolbar button order regressed in r175358 (Closed)

Created:
6 years, 6 months ago by apavlov
Modified:
6 years, 6 months ago
Reviewers:
eustas, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Restore toolbar button order regressed in r175358 The Dock button should be the rightmost one, otherwise it gets overlapped by a button to its right (Settings). R=eustas, pfeldman@chromium.org, vsevik BUG=383313 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/settings/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
apavlov
6 years, 6 months ago (2014-06-11 13:28:48 UTC) #1
eustas
lgtm
6 years, 6 months ago (2014-06-11 13:33:08 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-11 13:33:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/329113002/1
6 years, 6 months ago (2014-06-11 13:34:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-11 14:38:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 14:38:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16200)
6 years, 6 months ago (2014-06-11 14:38:58 UTC) #7
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-11 19:47:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/329113002/1
6 years, 6 months ago (2014-06-11 19:48:40 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 19:49:30 UTC) #10
Message was sent while issue was closed.
Change committed as 175978

Powered by Google App Engine
This is Rietveld 408576698