Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Code review. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
diff --git a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
index 80ebe8cb5d758e96c727c14bf247760112eab364..a58d7403973c07e05a0345b0984ea75b8c66ca01 100644
--- a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
+++ b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
@@ -32,6 +32,7 @@
#define RTCSessionDescriptionRequestImpl_h
#include "core/dom/ActiveDOMObject.h"
+#include "platform/heap/Handle.h"
#include "platform/mediastream/RTCSessionDescriptionRequest.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/PassRefPtr.h"
@@ -48,7 +49,7 @@ class RTCSessionDescriptionCallback;
class RTCSessionDescriptionRequestImpl FINAL : public RTCSessionDescriptionRequest, public ActiveDOMObject {
public:
- static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
+ static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassRefPtrWillBeRawPtr<RTCPeerConnection>, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
virtual ~RTCSessionDescriptionRequestImpl();
virtual void requestSucceeded(const blink::WebRTCSessionDescription&) OVERRIDE;
@@ -58,16 +59,16 @@ public:
virtual void stop() OVERRIDE;
private:
- RTCSessionDescriptionRequestImpl(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
+ RTCSessionDescriptionRequestImpl(ExecutionContext*, PassRefPtrWillBeRawPtr<RTCPeerConnection>, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
void clear();
OwnPtr<RTCSessionDescriptionCallback> m_successCallback;
OwnPtr<RTCErrorCallback> m_errorCallback;
+
+ RefPtrWillBePersistent<RTCPeerConnection> m_requester;
};
} // namespace WebCore
#endif // RTCSessionDescriptionRequestImpl_h
-
-
« no previous file with comments | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698