Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: LayoutTests/fast/mediastream/RTCPeerConnection-lifetime.html

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Code review. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/mediastream/RTCPeerConnection-lifetime-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/mediastream/RTCPeerConnection-lifetime.html
diff --git a/LayoutTests/fast/mediastream/RTCPeerConnection-lifetime.html b/LayoutTests/fast/mediastream/RTCPeerConnection-lifetime.html
index 076e0d3e553f4cacd149eb520ef97d93f59698a3..8ca415eb4af0955a8ec72206dbdaeef84b8889f2 100644
--- a/LayoutTests/fast/mediastream/RTCPeerConnection-lifetime.html
+++ b/LayoutTests/fast/mediastream/RTCPeerConnection-lifetime.html
@@ -7,8 +7,6 @@
<script>
description("Tests the RTCPeerConnection lifetime.");
-// This test times out if the Peer connection object is garbage collected.
-
var dc = null;
function dataChannelMessage(m)
@@ -24,7 +22,7 @@ function dataChannelOpen()
shouldNotThrow("dc.send('xyzzy');");
}
-function createPeerConnection()
+function createPeerConnectionAndDataChannel()
{
// The Peer Connection object is leaked
var pc = new webkitRTCPeerConnection({iceServers:[]}, null);
@@ -32,11 +30,33 @@ function createPeerConnection()
dc.onopen = dataChannelOpen;
}
-createPeerConnection();
-gc();
+var pcB = null;
+var observationB = null;
+
+// Test that the PeerConnection object is gc'd if close is called.
+var pcA = new webkitRTCPeerConnection(null, null);
+var observationA = internals.observeGC(pcA);
+pcA.close();
+pcA = null;
+asyncGC(function() {
+ shouldBeTrue('observationA.wasCollected');
+ observationA = null;
+
+ // Test that the PeerConnection object is not gc'd if close is not called.
+ pcB = new webkitRTCPeerConnection(null, null);
+ observationB = internals.observeGC(pcB);
+ pcB = null;
+ asyncGC(function() {
+ shouldBeFalse('observationB.wasCollected');
+ observationB = null;
+
+ // This test times out if the Peer connection object is garbage collected.
+ createPeerConnectionAndDataChannel();
+ gc();
+ });
+});
window.jsTestIsAsync = true;
-window.successfullyParsed = true;
</script>
</body>
</html>
« no previous file with comments | « no previous file | LayoutTests/fast/mediastream/RTCPeerConnection-lifetime-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698