Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: Source/modules/mediastream/RTCVoidRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCVoidRequestImpl.h
diff --git a/Source/modules/mediastream/RTCVoidRequestImpl.h b/Source/modules/mediastream/RTCVoidRequestImpl.h
index afea015c0070f6cd6570c893becfd034df746610..dd8f837b5eaa14741d2aaad99766047bb36788ee 100644
--- a/Source/modules/mediastream/RTCVoidRequestImpl.h
+++ b/Source/modules/mediastream/RTCVoidRequestImpl.h
@@ -37,11 +37,12 @@
namespace WebCore {
class RTCErrorCallback;
+class RTCPeerConnection;
class VoidCallback;
class RTCVoidRequestImpl FINAL : public RTCVoidRequest, public ActiveDOMObject {
public:
- static PassRefPtr<RTCVoidRequestImpl> create(ExecutionContext*, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
+ static PassRefPtr<RTCVoidRequestImpl> create(ExecutionContext*, PassRefPtr<RTCPeerConnection>, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
haraken 2014/06/15 13:43:58 PassRefPtrWillBeRawPtr
Henrik Grunell 2014/06/16 07:49:00 Done.
virtual ~RTCVoidRequestImpl();
// RTCVoidRequest
@@ -52,16 +53,16 @@ public:
virtual void stop() OVERRIDE;
private:
- RTCVoidRequestImpl(ExecutionContext*, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
+ RTCVoidRequestImpl(ExecutionContext*, PassRefPtr<RTCPeerConnection>, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
haraken 2014/06/15 13:43:57 PassRefPtrWillBeRawPtr
Henrik Grunell 2014/06/16 07:49:00 Done.
void clear();
OwnPtr<VoidCallback> m_successCallback;
OwnPtr<RTCErrorCallback> m_errorCallback;
+
+ RefPtr<RTCPeerConnection> m_requester;
haraken 2014/06/15 13:43:57 RefPtrWillBePersistent
Henrik Grunell 2014/06/16 07:49:00 Done.
};
} // namespace WebCore
#endif // RTCVoidRequestImpl_h
-
-

Powered by Google App Engine
This is Rietveld 408576698