Allow PeerConnection to be garbage collected after close().

Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

Index: Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
diff --git a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
index 80ebe8cb5d758e96c727c14bf247760112eab364..e88c9fc70ce2dfe3865f28323bca86b2c26e5afb 100644
--- a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
+++ b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h
@@ -48,7 +48,7 @@ class RTCSessionDescriptionCallback;
 
 class RTCSessionDescriptionRequestImpl FINAL : public RTCSessionDescriptionRequest, public ActiveDOMObject {
 public:
-    static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
+    static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassRefPtr<RTCPeerConnection>, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

[haraken, 2014/06/15 13:43:57]

RTCPeerConnection is already on oilpan's heap, so would you use
PassRefPtrWillBeRawPtr?

[Henrik Grunell, 2014/06/16 07:49:00]

I don't know much about oilpan. You know that better than me, should I? It seems
like RTCPeerConnection is on the oilpan's heap and
RTCSessionDescriptionRequestImpl is not, but how to pass ptrs for this case I
don't know. Changed it.

     virtual ~RTCSessionDescriptionRequestImpl();
 
     virtual void requestSucceeded(const blink::WebRTCSessionDescription&) OVERRIDE;
@@ -58,16 +58,16 @@ public:
     virtual void stop() OVERRIDE;
 
 private:
-    RTCSessionDescriptionRequestImpl(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
+    RTCSessionDescriptionRequestImpl(ExecutionContext*, PassRefPtr<RTCPeerConnection>, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

[haraken, 2014/06/15 13:43:57]

PassRefPtrWillBeRawPtr

[Henrik Grunell, 2014/06/16 07:49:00]

Done.

 
     void clear();
 
     OwnPtr<RTCSessionDescriptionCallback> m_successCallback;
     OwnPtr<RTCErrorCallback> m_errorCallback;
+
+    RefPtr<RTCPeerConnection> m_requester;

[haraken, 2014/06/15 13:43:57]

RefPtrWillBePersistent

[Henrik Grunell, 2014/06/16 07:49:00]

Done.

 };
 
 } // namespace WebCore
 
 #endif // RTCSessionDescriptionRequestImpl_h
-
-