Source/modules/mediastream/RTCVoidRequestImpl.h - Issue 329093002: Allow PeerConnection to be garbage collected after close().

Side by Side Diff: Source/modules/mediastream/RTCVoidRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Code review. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/modules/mediastream/RTCStatsRequestImpl.cpp ('K') | « Source/modules/mediastream/RTCStatsRequestImpl.cpp ('k') | Source/modules/mediastream/RTCVoidRequestImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 14 matching lines...) Expand all Loading...
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY	25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 #ifndef RTCVoidRequestImpl_h	31 #ifndef RTCVoidRequestImpl_h

32 #define RTCVoidRequestImpl_h	32 #define RTCVoidRequestImpl_h

33	33

34 #include "core/dom/ActiveDOMObject.h"	34 #include "core/dom/ActiveDOMObject.h"

	35 #include "platform/heap/Handle.h"

35 #include "platform/mediastream/RTCVoidRequest.h"	36 #include "platform/mediastream/RTCVoidRequest.h"

36	37

37 namespace WebCore {	38 namespace WebCore {

38	39

39 class RTCErrorCallback;	40 class RTCErrorCallback;

	41 class RTCPeerConnection;

40 class VoidCallback;	42 class VoidCallback;

41	43

42 class RTCVoidRequestImpl FINAL : public RTCVoidRequest, public ActiveDOMObject {	44 class RTCVoidRequestImpl FINAL : public RTCVoidRequest, public ActiveDOMObject {

43 public:	45 public:

44 static PassRefPtr<RTCVoidRequestImpl> create(ExecutionContext*, PassOwnPtr<V oidCallback>, PassOwnPtr<RTCErrorCallback>);	46 static PassRefPtr<RTCVoidRequestImpl> create(ExecutionContext*, PassRefPtrWi llBeRawPtr<RTCPeerConnection>, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCall back>);

45 virtual ~RTCVoidRequestImpl();	47 virtual ~RTCVoidRequestImpl();

46	48

47 // RTCVoidRequest	49 // RTCVoidRequest

48 virtual void requestSucceeded() OVERRIDE;	50 virtual void requestSucceeded() OVERRIDE;

49 virtual void requestFailed(const String& error) OVERRIDE;	51 virtual void requestFailed(const String& error) OVERRIDE;

50	52

51 // ActiveDOMObject	53 // ActiveDOMObject

52 virtual void stop() OVERRIDE;	54 virtual void stop() OVERRIDE;

53	55

54 private:	56 private:

55 RTCVoidRequestImpl(ExecutionContext*, PassOwnPtr<VoidCallback>, PassOwnPtr<R TCErrorCallback>);	57 RTCVoidRequestImpl(ExecutionContext*, PassRefPtrWillBeRawPtr<RTCPeerConnecti on>, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);

56	58

57 void clear();	59 void clear();

58	60

59 OwnPtr<VoidCallback> m_successCallback;	61 OwnPtr<VoidCallback> m_successCallback;

60 OwnPtr<RTCErrorCallback> m_errorCallback;	62 OwnPtr<RTCErrorCallback> m_errorCallback;

	63

	64 RefPtrWillBePersistent<RTCPeerConnection> m_requester;

61 };	65 };

62	66

63 } // namespace WebCore	67 } // namespace WebCore

64	68

65 #endif // RTCVoidRequestImpl_h	69 #endif // RTCVoidRequestImpl_h

66

67

OLD	NEW