Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/modules/mediastream/RTCStatsRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Code review. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y 16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y
17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N 19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N
20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS 21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */ 23 */
24 24
25 #ifndef RTCStatsRequestImpl_h 25 #ifndef RTCStatsRequestImpl_h
26 #define RTCStatsRequestImpl_h 26 #define RTCStatsRequestImpl_h
27 27
28 #include "core/dom/ActiveDOMObject.h" 28 #include "core/dom/ActiveDOMObject.h"
29 #include "modules/mediastream/RTCStatsResponse.h" 29 #include "modules/mediastream/RTCStatsResponse.h"
30 #include "platform/heap/Handle.h"
30 #include "platform/mediastream/RTCStatsRequest.h" 31 #include "platform/mediastream/RTCStatsRequest.h"
31 #include "wtf/PassRefPtr.h" 32 #include "wtf/PassRefPtr.h"
32 #include "wtf/RefCounted.h" 33 #include "wtf/RefCounted.h"
33 #include "wtf/text/WTFString.h" 34 #include "wtf/text/WTFString.h"
34 35
35 namespace WebCore { 36 namespace WebCore {
36 37
37 class MediaStreamTrack; 38 class MediaStreamTrack;
39 class RTCPeerConnection;
38 class RTCStatsCallback; 40 class RTCStatsCallback;
39 41
40 class RTCStatsRequestImpl FINAL : public RTCStatsRequest, public ActiveDOMObject { 42 class RTCStatsRequestImpl FINAL : public RTCStatsRequest, public ActiveDOMObject {
41 public: 43 public:
42 static PassRefPtr<RTCStatsRequestImpl> create(ExecutionContext*, PassOwnPtr< RTCStatsCallback>, PassRefPtr<MediaStreamTrack>); 44 static PassRefPtr<RTCStatsRequestImpl> create(ExecutionContext*, PassRefPtrW illBeRawPtr<RTCPeerConnection>, PassOwnPtr<RTCStatsCallback>, PassRefPtr<MediaSt reamTrack>);
43 virtual ~RTCStatsRequestImpl(); 45 virtual ~RTCStatsRequestImpl();
44 46
45 virtual PassRefPtrWillBeRawPtr<RTCStatsResponseBase> createResponse() OVERRI DE; 47 virtual PassRefPtrWillBeRawPtr<RTCStatsResponseBase> createResponse() OVERRI DE;
46 virtual bool hasSelector() OVERRIDE; 48 virtual bool hasSelector() OVERRIDE;
47 virtual MediaStreamComponent* component() OVERRIDE; 49 virtual MediaStreamComponent* component() OVERRIDE;
48 50
49 virtual void requestSucceeded(PassRefPtrWillBeRawPtr<RTCStatsResponseBase>) OVERRIDE; 51 virtual void requestSucceeded(PassRefPtrWillBeRawPtr<RTCStatsResponseBase>) OVERRIDE;
50 52
51 // ActiveDOMObject 53 // ActiveDOMObject
52 virtual void stop() OVERRIDE; 54 virtual void stop() OVERRIDE;
53 55
54 private: 56 private:
55 RTCStatsRequestImpl(ExecutionContext*, PassOwnPtr<RTCStatsCallback>, PassRef Ptr<MediaStreamTrack>); 57 RTCStatsRequestImpl(ExecutionContext*, PassRefPtrWillBeRawPtr<RTCPeerConnect ion>, PassOwnPtr<RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);
56 58
57 void clear(); 59 void clear();
58 60
59 OwnPtr<RTCStatsCallback> m_successCallback; 61 OwnPtr<RTCStatsCallback> m_successCallback;
60 RefPtr<MediaStreamComponent> m_component; 62 RefPtr<MediaStreamComponent> m_component;
63
64 RefPtrWillBePersistent<RTCPeerConnection> m_requester;
61 }; 65 };
62 66
63 } // namespace WebCore 67 } // namespace WebCore
64 68
65 #endif // RTCStatsRequestImpl_h 69 #endif // RTCStatsRequestImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698