Source/modules/mediastream/RTCStatsRequestImpl.h - Issue 329093002: Allow PeerConnection to be garbage collected after close().

Side by Side Diff: Source/modules/mediastream/RTCStatsRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp ('K') | « Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp ('k') | Source/modules/mediastream/RTCStatsRequestImpl.cpp » ('j') | Source/modules/mediastream/RTCVoidRequestImpl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 17 matching lines...) Expand all Loading...
28 #include "core/dom/ActiveDOMObject.h"	28 #include "core/dom/ActiveDOMObject.h"

29 #include "modules/mediastream/RTCStatsResponse.h"	29 #include "modules/mediastream/RTCStatsResponse.h"

30 #include "platform/mediastream/RTCStatsRequest.h"	30 #include "platform/mediastream/RTCStatsRequest.h"

31 #include "wtf/PassRefPtr.h"	31 #include "wtf/PassRefPtr.h"

32 #include "wtf/RefCounted.h"	32 #include "wtf/RefCounted.h"

33 #include "wtf/text/WTFString.h"	33 #include "wtf/text/WTFString.h"

34	34

35 namespace WebCore {	35 namespace WebCore {

36	36

37 class MediaStreamTrack;	37 class MediaStreamTrack;

	38 class RTCPeerConnection;

38 class RTCStatsCallback;	39 class RTCStatsCallback;

39	40

40 class RTCStatsRequestImpl FINAL : public RTCStatsRequest, public ActiveDOMObject {	41 class RTCStatsRequestImpl FINAL : public RTCStatsRequest, public ActiveDOMObject {

41 public:	42 public:

42 static PassRefPtr<RTCStatsRequestImpl> create(ExecutionContext*, PassOwnPtr< RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);	43 static PassRefPtr<RTCStatsRequestImpl> create(ExecutionContext*, PassRefPtr< RTCPeerConnection>, PassOwnPtr<RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);
	haraken 2014/06/15 13:43:57 PassRefPtrWillBeRawPtr PassRefPtrWillBeRawPtr Henrik Grunell 2014/06/16 07:49:00 Done. Show quoted text On 2014/06/15 13:43:57, haraken wrote: > > PassRefPtrWillBeRawPtr Done.
43 virtual ~RTCStatsRequestImpl();	44 virtual ~RTCStatsRequestImpl();

44	45

45 virtual PassRefPtrWillBeRawPtr<RTCStatsResponseBase> createResponse() OVERRI DE;	46 virtual PassRefPtrWillBeRawPtr<RTCStatsResponseBase> createResponse() OVERRI DE;

46 virtual bool hasSelector() OVERRIDE;	47 virtual bool hasSelector() OVERRIDE;

47 virtual MediaStreamComponent* component() OVERRIDE;	48 virtual MediaStreamComponent* component() OVERRIDE;

48	49

49 virtual void requestSucceeded(PassRefPtrWillBeRawPtr<RTCStatsResponseBase>) OVERRIDE;	50 virtual void requestSucceeded(PassRefPtrWillBeRawPtr<RTCStatsResponseBase>) OVERRIDE;

50	51

51 // ActiveDOMObject	52 // ActiveDOMObject

52 virtual void stop() OVERRIDE;	53 virtual void stop() OVERRIDE;

53	54

54 private:	55 private:

55 RTCStatsRequestImpl(ExecutionContext*, PassOwnPtr<RTCStatsCallback>, PassRef Ptr<MediaStreamTrack>);	56 RTCStatsRequestImpl(ExecutionContext*, PassRefPtr<RTCPeerConnection>, PassOw nPtr<RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);
	haraken 2014/06/15 13:43:57 PassRefPtrWillBeRawPtr PassRefPtrWillBeRawPtr Henrik Grunell 2014/06/16 07:49:00 Done. Show quoted text On 2014/06/15 13:43:57, haraken wrote: > > PassRefPtrWillBeRawPtr Done.
56	57

57 void clear();	58 void clear();

58	59

59 OwnPtr<RTCStatsCallback> m_successCallback;	60 OwnPtr<RTCStatsCallback> m_successCallback;

60 RefPtr<MediaStreamComponent> m_component;	61 RefPtr<MediaStreamComponent> m_component;

	62

	63 RefPtr<RTCPeerConnection> m_requester;
	haraken 2014/06/15 13:43:57 RefPtrWillBePersistent RefPtrWillBePersistent Henrik Grunell 2014/06/16 07:49:00 Done. Show quoted text On 2014/06/15 13:43:57, haraken wrote: > > RefPtrWillBePersistent Done.
61 };	64 };

62	65

63 } // namespace WebCore	66 } // namespace WebCore

64	67

65 #endif // RTCStatsRequestImpl_h	68 #endif // RTCStatsRequestImpl_h

OLD	NEW