Allow PeerConnection to be garbage collected after close().

Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 30 matching lines @@
 }
 
 namespace WebCore {
 
 class RTCErrorCallback;
 class RTCPeerConnection;
 class RTCSessionDescriptionCallback;
 
 class RTCSessionDescriptionRequestImpl FINAL : public RTCSessionDescriptionRequest, public ActiveDOMObject {
 public:
-    static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
+    static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassRefPtr<RTCPeerConnection>, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

[haraken, 2014/06/15 13:43:57]

RTCPeerConnection is already on oilpan's heap, so would you use
PassRefPtrWillBeRawPtr?

[Henrik Grunell, 2014/06/16 07:49:00]

I don't know much about oilpan. You know that better than me, should I? It seems
like RTCPeerConnection is on the oilpan's heap and
RTCSessionDescriptionRequestImpl is not, but how to pass ptrs for this case I
don't know. Changed it.

     virtual ~RTCSessionDescriptionRequestImpl();
 
     virtual void requestSucceeded(const blink::WebRTCSessionDescription&) OVERRIDE;
     virtual void requestFailed(const String& error) OVERRIDE;
 
     // ActiveDOMObject
     virtual void stop() OVERRIDE;
 
 private:
-    RTCSessionDescriptionRequestImpl(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);
+    RTCSessionDescriptionRequestImpl(ExecutionContext*, PassRefPtr<RTCPeerConnection>, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

[haraken, 2014/06/15 13:43:57]

PassRefPtrWillBeRawPtr

[Henrik Grunell, 2014/06/16 07:49:00]

Done.

 
     void clear();
 
     OwnPtr<RTCSessionDescriptionCallback> m_successCallback;
     OwnPtr<RTCErrorCallback> m_errorCallback;
+
+    RefPtr<RTCPeerConnection> m_requester;

[haraken, 2014/06/15 13:43:57]

RefPtrWillBePersistent

[Henrik Grunell, 2014/06/16 07:49:00]

Done.

 };
 
 } // namespace WebCore
 
 #endif // RTCSessionDescriptionRequestImpl_h
-
-