Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 329063002: Version 3.26.31.3 (merged r21299) (Closed)

Created:
6 years, 6 months ago by ulan
Modified:
6 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Version 3.26.31.3 (merged r21299) Skip write barriers when updating the weak hash table. BUG=359401, 378206 LOG=N R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
M src/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL, patch applied cleanly.
6 years, 6 months ago (2014-06-11 06:48:57 UTC) #1
Sven Panne
LGTM (rubber-stamped)
6 years, 6 months ago (2014-06-11 06:50:15 UTC) #2
ulan
6 years, 6 months ago (2014-06-11 07:08:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21757.

Powered by Google App Engine
This is Rietveld 408576698