Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: ui/views/controls/webview/webview.cc

Issue 329053004: Fix race in BrowserAccessibilityManagerWin creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/webview/webview.cc
diff --git a/ui/views/controls/webview/webview.cc b/ui/views/controls/webview/webview.cc
index 21de72612313f43c5556053536e66379ade07c14..051dbaf0953396fe1a4749629889acde67d91a86 100644
--- a/ui/views/controls/webview/webview.cc
+++ b/ui/views/controls/webview/webview.cc
@@ -298,23 +298,11 @@ void WebView::AttachWebContents() {
FocusManager* const focus_manager = GetFocusManager();
if (focus_manager && focus_manager->GetFocusedView() == this)
OnFocus();
-
-#if defined(OS_WIN)
- if (!is_embedding_fullscreen_widget_) {
- web_contents()->SetParentNativeViewAccessible(
- parent()->GetNativeViewAccessible());
- }
-#endif
}
void WebView::DetachWebContents() {
- if (web_contents()) {
+ if (web_contents())
holder_->Detach();
-#if defined(OS_WIN)
- if (!is_embedding_fullscreen_widget_)
- web_contents()->SetParentNativeViewAccessible(NULL);
-#endif
- }
}
void WebView::ReattachForFullscreenChange(bool enter_fullscreen) {

Powered by Google App Engine
This is Rietveld 408576698