Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: Source/core/events/EventTarget.idl

Issue 329053002: Throw TypeError when addEventListener or removeEventListener are called without enough arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.idl
diff --git a/Source/core/events/EventTarget.idl b/Source/core/events/EventTarget.idl
index 69a4bc18d7b6e8986ae9c3dbe76371cd5ae3ba73..08329aa268ad18a559963b0dbfde4d48b5b92fb2 100644
--- a/Source/core/events/EventTarget.idl
+++ b/Source/core/events/EventTarget.idl
@@ -18,17 +18,23 @@
* Boston, MA 02110-1301, USA.
*/
+// http://dom.spec.whatwg.org/#interface-eventtarget
+
[
+ // FIXME: should use [CheckSecurity=Frame] http://crbug.com/383699
+ // CheckSecurity=Frame,
Custom=ToV8,
WillBeGarbageCollected,
] interface EventTarget {
- // FIXME: first 2 args should be required, but throwing TypeError breaks
- // legacy content. http://crbug.com/353484
- void addEventListener([TreatNullAs=NullString] optional DOMString type,
- optional EventListener listener,
+ void addEventListener([TreatNullAs=NullString] DOMString type,
+ EventListener? listener,
+ // FIXME: should be useCapture = false
+ // http://crbug.com/258153
optional boolean useCapture);
- void removeEventListener([TreatNullAs=NullString] optional DOMString type,
- optional EventListener listener,
+ void removeEventListener([TreatNullAs=NullString] DOMString type,
+ EventListener? listener,
+ // FIXME: should be useCapture = false
+ // http://crbug.com/258153
optional boolean useCapture);
[RaisesException] boolean dispatchEvent(Event event);
};
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698