Source/bindings/templates/methods.cpp - Issue 329053002: Throw TypeError when addEventListener or removeEventListener are called without enough arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 329053002: Throw TypeError when addEventListener or removeEventListener are called without enough arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index 4a44e7228dc0ce23b2376546459023e7542a645f..33651722f4bcfeb0e3810b033539f4b10b128f3d 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -21,7 +21,7 @@ static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const

CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

{% endif %}

{# Security checks #}

- {# FIXME: change to method.is_check_security_for_window #}

+ {# FIXME: merge to method.is_check_security_for_frame http://crbug.com/383699 #}

{% if interface_name == 'EventTarget' %}

if (LocalDOMWindow* window = impl->toDOMWindow()) {

if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), window->frame(), exceptionState)) {

« no previous file with comments | « Source/bindings/templates/interface.cpp ('k') | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »