Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 329053002: Throw TypeError when addEventListener or removeEventListener are called without enough arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index f8c83faf67d984bacdbaaf9d35f5155f97fc4052..9869a50cb1479b1c92cdfba83cf6b207c202a4f1 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -290,9 +290,9 @@ INCLUDES_FOR_TYPE = {
'Dictionary': set(['bindings/v8/Dictionary.h']),
'EventHandler': set(['bindings/v8/V8AbstractEventListener.h',
'bindings/v8/V8EventListenerList.h']),
- 'EventListener': set(['bindings/v8/BindingSecurity.h',
+ 'EventListener': set(['bindings/v8/BindingSecurity.h', # FIXME: replace with [CheckSecurity=Frame] http://crbug.com/383699
'bindings/v8/V8EventListenerList.h',
- 'core/frame/LocalDOMWindow.h']),
+ 'core/frame/LocalDOMWindow.h']), # FIXME: move to EventTarget::frame
'HTMLCollection': set(['bindings/core/v8/V8HTMLCollection.h',
'core/dom/ClassCollection.h',
'core/dom/TagCollection.h',
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698