Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: Source/core/events/EventTarget.idl

Issue 329053002: Throw TypeError when addEventListener or removeEventListener are called without enough arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 // http://dom.spec.whatwg.org/#interface-eventtarget
22
21 [ 23 [
22 Custom=ToV8, 24 Custom=ToV8,
25 // TypeChecking=Nullable,
23 WillBeGarbageCollected, 26 WillBeGarbageCollected,
24 ] interface EventTarget { 27 ] interface EventTarget {
25 // FIXME: first 2 args should be required, but throwing TypeError breaks 28 void addEventListener([TreatNullAs=NullString] DOMString type,
26 // legacy content. http://crbug.com/353484 29 // FIXME: should be nullable
27 void addEventListener([TreatNullAs=NullString] optional DOMString type, 30 EventListener listener,
28 optional EventListener listener, 31 // FIXME: should be useCapture = false
32 // http://crbug.com/258153
29 optional boolean useCapture); 33 optional boolean useCapture);
30 void removeEventListener([TreatNullAs=NullString] optional DOMString type, 34 void removeEventListener([TreatNullAs=NullString] DOMString type,
31 optional EventListener listener, 35 // FIXME: should be nullable
36 EventListener listener,
37 // FIXME: should be useCapture = false
38 // http://crbug.com/258153
32 optional boolean useCapture); 39 optional boolean useCapture);
33 [RaisesException] boolean dispatchEvent(Event event); 40 [RaisesException] boolean dispatchEvent(Event event);
34 }; 41 };
OLDNEW
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698