Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 329033002: Use dpi from PrintSettings for PDF to EMF conversion. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
Noam Samuel, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Use dpi from PrintSettings for PDF to EMF conversion. BUG=379961 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-11 05:31:18 UTC) #1
scottmg
Thanks for looking into this Vitaly. This doesn't seem to be enough unfortunately. I tried ...
6 years, 6 months ago (2014-06-11 17:21:08 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2014/06/11 17:21:08, scottmg wrote: > Thanks for looking into this Vitaly. This doesn't seem ...
6 years, 6 months ago (2014-06-11 17:29:49 UTC) #3
Noam Samuel
lgtm lgtm
6 years, 6 months ago (2014-06-11 18:11:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/329033002/1
6 years, 6 months ago (2014-06-11 18:13:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:39:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:00:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26090)
6 years, 6 months ago (2014-06-11 21:00:39 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 00:51:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/329033002/1
6 years, 6 months ago (2014-06-12 00:53:26 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 01:06:55 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 02:17:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26382)
6 years, 6 months ago (2014-06-12 02:17:04 UTC) #13
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 06:53:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/329033002/1
6 years, 6 months ago (2014-06-12 06:57:22 UTC) #15
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 07:54:27 UTC) #16
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 07:54:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/329033002/1
6 years, 6 months ago (2014-06-12 07:58:58 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 08:07:30 UTC) #19
Message was sent while issue was closed.
Change committed as 276577

Powered by Google App Engine
This is Rietveld 408576698