Chromium Code Reviews
Help | Chromium Project | Sign in
(238)

Issue 329015: Look up client certificates in ClientAuthHandler to get rid of manual CA... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
Jaime Soriano
CC:
chromium-reviews_googlegroups.com, darin
Visibility:
Public.

Description

Look up client certificates in ClientAuthHandler to get rid of manual CA
names list copy.

Patch by Jaime Soriano <jsorianopastor@gmail.com>;.
Original review URL: http://codereview.chromium.org/302004

R=wtc
BUG=16830
TEST=Try to connect to a web page that requires SSL authentication and
confirm that it connects if and only if a valid certificate is stored in
.pki/nssdb database.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29994

Patch Set 1 #

Patch Set 2 : Minor edits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -52 lines) Lint Patch
M net/socket/ssl_client_socket_nss.h View 1 2 chunks +2 lines, -1 line 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.cc View 1 5 chunks +34 lines, -51 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 2
wtc
Jaime, I've checked in your patch. You can look at the delta between Patch Sets ...
4 years, 5 months ago #1
Jaime Soriano
4 years, 5 months ago #2
On 2009/10/24 04:06:20, wtc wrote:
> Jaime,
> 
> I've checked in your patch.  You can look at the delta between
> Patch Sets 1 and 2 to see the changes I made.
Ok, thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434