Issue 329015: Look up client certificates in ClientAuthHandler to get rid of manual CA...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329015: Look up client certificates in ClientAuthHandler to get rid of manual CA... (Closed)

Created:
11 years, 2 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
Jaime Soriano

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Look up client certificates in ClientAuthHandler to get rid of manual CA names list copy. Patch by Jaime Soriano <jsorianopastor@gmail.com>;. Original review URL: http://codereview.chromium.org/302004 R=wtc BUG=16830 TEST=Try to connect to a web page that requires SSL authentication and confirm that it connects if and only if a valid certificate is stored in .pki/nssdb database. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29994

Patch Set 1 #

Patch Set 2 : Minor edits #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -52 lines)			Patch
	M	net/socket/ssl_client_socket_nss.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
	M	net/socket/ssl_client_socket_nss.cc	View	1	5 chunks	+34 lines, -51 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

Jaime, I've checked in your patch. You can look at the delta between Patch Sets ...

11 years, 2 months ago (2009-10-24 04:06:20 UTC) #1

Jaime Soriano

11 years, 2 months ago (2009-10-24 09:36:12 UTC) #2

On 2009/10/24 04:06:20, wtc wrote:
> Jaime,
> 
> I've checked in your patch.  You can look at the delta between
> Patch Sets 1 and 2 to see the changes I made.
Ok, thank you.

Expand Messages | Collapse Messages