Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329003002: Cleanup: Remove DCHECK failure handling in DelegatedFrameHost. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove DCHECK failure handling in DelegatedFrameHost. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276659

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M content/browser/compositor/delegated_frame_host.cc View 6 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
6 years, 6 months ago (2014-06-11 02:43:11 UTC) #1
danakj
lgtm
6 years, 6 months ago (2014-06-11 14:27:15 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 6 months ago (2014-06-11 14:27:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/329003002/20001
6 years, 6 months ago (2014-06-11 14:30:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:38:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:42:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19785)
6 years, 6 months ago (2014-06-11 22:42:20 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-12 05:05:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/329003002/20001
6 years, 6 months ago (2014-06-12 05:09:18 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 13:29:37 UTC) #10
Message was sent while issue was closed. 
Change committed as 276659

Powered by Google App Engine
This is Rietveld 408576698