Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2928)

Unified Diff: chrome/browser/extensions/extension_page_actions_module.cc

Issue 329001: Remove pageAction badge functions (Closed)
Patch Set: pre commit Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_page_actions_module.cc
diff --git a/chrome/browser/extensions/extension_page_actions_module.cc b/chrome/browser/extensions/extension_page_actions_module.cc
index 47388914e1cec7e985acb5f1343862bd9bdce854..b39ca32c8854ac22efa2f8d66d5dca8107119347 100644
--- a/chrome/browser/extensions/extension_page_actions_module.cc
+++ b/chrome/browser/extensions/extension_page_actions_module.cc
@@ -192,6 +192,8 @@ bool PageActionSetTitleFunction::RunImpl() {
return true;
}
+// Not currently exposed to extensions. To re-enable, add mapping in
+// extension_function_dispatcher.
bool PageActionSetBadgeBackgroundColorFunction::RunImpl() {
EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
const DictionaryValue* args = static_cast<const DictionaryValue*>(args_);
@@ -216,6 +218,8 @@ bool PageActionSetBadgeBackgroundColorFunction::RunImpl() {
return true;
}
+// Not currently exposed to extensions. To re-enable, add mapping in
+// extension_function_dispatcher.
bool PageActionSetBadgeTextColorFunction::RunImpl() {
EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
const DictionaryValue* args = static_cast<const DictionaryValue*>(args_);
@@ -240,6 +244,8 @@ bool PageActionSetBadgeTextColorFunction::RunImpl() {
return true;
}
+// Not currently exposed to extensions. To re-enable, add mapping in
+// extension_function_dispatcher.
bool PageActionSetBadgeTextFunction::RunImpl() {
EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));
const DictionaryValue* args = static_cast<const DictionaryValue*>(args_);
« no previous file with comments | « chrome/browser/extensions/extension_function_dispatcher.cc ('k') | chrome/common/extensions/api/extension_api.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698