Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 329001: Remove pageAction badge functions (Closed)

Created:
11 years, 2 months ago by rafaelw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove pageAction setXXXBadge functions. This only removes the binding to the functions, not their implementation, as we may want to bring back badges for pageActions if we can make them look good. BUG=25552 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29977

Patch Set 1 #

Patch Set 2 : pre commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -614 lines) Patch
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 1 chunk +0 lines, -65 lines 0 comments Download
M chrome/common/extensions/docs/pageAction.html View 1 4 chunks +4 lines, -546 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rafaelw
11 years, 2 months ago (2009-10-22 23:32:05 UTC) #1
Matt Perry
lgtm
11 years, 2 months ago (2009-10-22 23:35:25 UTC) #2
Kathy Walrath
We also need to revise static/pageAction.html to except badges from the list of browser-action-like things ...
11 years, 2 months ago (2009-10-23 02:58:40 UTC) #3
Aaron Boodman
We are also not currently looking like we are going to get popups for page ...
11 years, 2 months ago (2009-10-23 03:06:00 UTC) #4
Kathy Walrath
11 years, 2 months ago (2009-10-23 04:51:24 UTC) #5
OK, I'll take those out, too.

-k-

On Thu, Oct 22, 2009 at 8:05 PM, Aaron Boodman <aa@chromium.org> wrote:
>
> We are also not currently looking like we are going to get popups for
> page actions in for beta, so I recommend taking any references to that
> out for now.
>
> Sorry about the back and forth.
>
> - a
>
> On Thu, Oct 22, 2009 at 7:58 PM, =A0<kathyw@google.com> wrote:
>>
>> We also need to revise static/pageAction.html to except badges from the =
list
>> of
>> browser-action-like things page actions support.
>>
>> I can do this, if you like.
>>
>> http://codereview.chromium.org/329001
>>
>

Powered by Google App Engine
This is Rietveld 408576698