Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 328993003: Drop dependency on Isolate* from platform.h (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Drop dependency on Isolate* from platform.h BUG=none R=dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21819

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -63 lines) Patch
M src/log.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/log.cc View 1 2 chunks +8 lines, -16 lines 0 comments Download
M src/platform.h View 1 2 chunks +13 lines, -1 line 0 comments Download
M src/platform-cygwin.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/platform-freebsd.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/platform-linux.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/platform-macos.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/platform-openbsd.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/platform-qnx.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download
M src/platform-solaris.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-win32.cc View 1 2 5 chunks +31 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-11 03:13:21 UTC) #1
Benedikt Meurer
LGTM
6 years, 6 months ago (2014-06-11 03:58:43 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-12 17:06:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698