Ensure that the size passed down to the SetDragImageOnDataObject function called from drag_utils::S…

Ensure that size passed into drag_utils_win.cc's SetDragImageOnDataObject function is in pixels and is obtained from the SkBitmap instance.

This is needed for the drag image to show up without being clipped.

Removed the size parameter from the drag_utils::SetDragImageOnDataObject functions as it is not needed. We can get the size from the ImageSkia object as needed.

BUG=381611
R=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276725

[sky, 2014-06-11 15:57:17]

https://codereview.chromium.org/328993002/diff/40001/ui/base/dragdrop/drag_ut...
File ui/base/dragdrop/drag_utils.cc (right):

https://codereview.chromium.org/328993002/diff/40001/ui/base/dragdrop/drag_ut...
ui/base/dragdrop/drag_utils.cc:106:
gfx::ToCeiledSize(gfx::ScaleSize(size_in_dips, canvas.image_scale())),
With few exceptions every where should take dips. If callers aren't calling
SetDragImageOnDataObject with dips, you should change them and not this.

[ananta, 2014-06-11 18:54:03]

https://codereview.chromium.org/328993002/diff/40001/ui/base/dragdrop/drag_ut...
File ui/base/dragdrop/drag_utils.cc (right):

https://codereview.chromium.org/328993002/diff/40001/ui/base/dragdrop/drag_ut...
ui/base/dragdrop/drag_utils.cc:106:
gfx::ToCeiledSize(gfx::ScaleSize(size_in_dips, canvas.image_scale())),
On 2014/06/11 15:57:17, sky wrote:
> With few exceptions every where should take dips. If callers aren't calling
> SetDragImageOnDataObject with dips, you should change them and not this.

As per our discussion removed the size parameter from the
SetDragImageOnDataObject functions and passed down the size from SkBitmap to the
function which needs it.

[sky, 2014-06-11 19:56:03]

LGTM

[ananta, 2014-06-12 11:59:47]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-06-12 12:02:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/328993002/80001

[commit-bot: I haz the power, 2014-06-12 17:20:46]

Change committed as 276725