Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Issue 328973002: Add description for WebFont.PackageFormat histogram (Closed)

Created:
6 years, 6 months ago by Kunihiko Sakamoto
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add description for WebFont.PackageFormat histogram Blink-side change: https://codereview.chromium.org/324003002/ BUG=380988 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276558

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make Unknown the first bucket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Kunihiko Sakamoto
6 years, 6 months ago (2014-06-11 02:13:57 UTC) #1
Ilya Sherman
LGTM with a suggestion: https://codereview.chromium.org/328973002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/328973002/diff/1/tools/metrics/histograms/histograms.xml#newcode44916 tools/metrics/histograms/histograms.xml:44916: + <int value="4" label="Unknown / ...
6 years, 6 months ago (2014-06-11 20:01:31 UTC) #2
Kunihiko Sakamoto
https://codereview.chromium.org/328973002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/328973002/diff/1/tools/metrics/histograms/histograms.xml#newcode44916 tools/metrics/histograms/histograms.xml:44916: + <int value="4" label="Unknown / Decode error"/> On 2014/06/11 ...
6 years, 6 months ago (2014-06-12 01:44:26 UTC) #3
Kunihiko Sakamoto
The CQ bit was checked by ksakamoto@chromium.org
6 years, 6 months ago (2014-06-12 01:44:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/328973002/20001
6 years, 6 months ago (2014-06-12 01:45:18 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 07:16:35 UTC) #6
Message was sent while issue was closed.
Change committed as 276558

Powered by Google App Engine
This is Rietveld 408576698