chrome/common/extensions/permissions/chrome_permission_message_provider.cc - Issue 328943002: Change topSites API permission warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

Issue 328943002: Change topSites API permission warning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

index 9fb3c84fe4c268383e51a1132b92be1b98c147a4..6fa8e5b9c0e14fbaf31c5074cdf31ba242b6a184 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

@@ -164,13 +164,13 @@ std::vector<base::string16> ChromePermissionMessageProvider::GetWarningMessages(

if (permissions->HasAPIPermission(APIPermission::kSessions) &&

id == PermissionMessage::kTabs) {

message_strings.push_back(l10n_util::GetStringUTF16(

- IDS_EXTENSION_PROMPT_WARNING_TABS_AND_SESSIONS));

+ IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS));

continue;

}

if (permissions->HasAPIPermission(APIPermission::kSessions) &&

id == PermissionMessage::kBrowsingHistory) {

message_strings.push_back(l10n_util::GetStringUTF16(

- IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY_AND_SESSIONS));

+ IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE_AND_SESSIONS));

continue;

}