chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 328943002: Change topSites API permission warning

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 328943002: Change topSites API permission warning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_install_prompt_experiment.cc ('k') | chrome/common/extensions/permissions/chrome_permission_message_provider.cc » ('j') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index 330ee12ad971a98ed2b425ddf776b5a6b592f376..373a7b53bac8e6252b6647a2bd4c2da5827a7e36 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -106,8 +106,8 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{APIPermission::kFontSettings, "fontSettings",

APIPermissionInfo::kFlagCannotBeOptional},

{APIPermission::kHistory, "history", APIPermissionInfo::kFlagNone,

- IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY,

- PermissionMessage::kBrowsingHistory},

+ IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE,

+ PermissionMessage::kBrowsingHistoryWrite},

{APIPermission::kIdltest, "idltest"},

{APIPermission::kIdle, "idle"},

{APIPermission::kInfobars, "infobars"},

@@ -128,7 +128,8 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{APIPermission::kPrivacy, "privacy", APIPermissionInfo::kFlagNone,

IDS_EXTENSION_PROMPT_WARNING_PRIVACY, PermissionMessage::kPrivacy},

{APIPermission::kProcesses, "processes", APIPermissionInfo::kFlagNone,

- IDS_EXTENSION_PROMPT_WARNING_TABS, PermissionMessage::kTabs},

+ IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,

+ PermissionMessage::kBrowsingHistoryRead},

{APIPermission::kSessions, "sessions"},

{APIPermission::kSignedInDevices, "signedInDevices",

APIPermissionInfo::kFlagNone,

@@ -139,10 +140,11 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

IDS_EXTENSION_PROMPT_WARNING_SYNCFILESYSTEM,

PermissionMessage::kSyncFileSystem},

{APIPermission::kTab, "tabs", APIPermissionInfo::kFlagNone,

- IDS_EXTENSION_PROMPT_WARNING_TABS, PermissionMessage::kTabs},

+ IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,

+ PermissionMessage::kBrowsingHistoryRead},

{APIPermission::kTopSites, "topSites", APIPermissionInfo::kFlagNone,

- IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY,

- PermissionMessage::kBrowsingHistory},

+ IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,

+ PermissionMessage::kBrowsingHistoryRead},

{APIPermission::kTts, "tts", 0, APIPermissionInfo::kFlagCannotBeOptional},

{APIPermission::kTtsEngine, "ttsEngine",

APIPermissionInfo::kFlagCannotBeOptional,

@@ -151,8 +153,8 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

APIPermissionInfo::kFlagCannotBeOptional,

IDS_EXTENSION_PROMPT_WARNING_WALLPAPER, PermissionMessage::kWallpaper},

{APIPermission::kWebNavigation, "webNavigation",

- APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_TABS,

- PermissionMessage::kTabs},

+ APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,

+ PermissionMessage::kBrowsingHistoryRead},

{APIPermission::kWebRequest, "webRequest"},

{APIPermission::kWebRequestBlocking, "webRequestBlocking"},

{APIPermission::kWebView, "webview",