Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/extensions/extension_install_prompt_experiment.cc

Issue 328943002: Change topSites API permission warning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/metrics/field_trial.h" 7 #include "base/metrics/field_trial.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/string_split.h" 9 #include "base/strings/string_split.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 }; 132 };
133 133
134 // Permission warnings in this list are going to be highlighted. 134 // Permission warnings in this list are going to be highlighted.
135 // Note that the matching is done by string comparison, so this list must not 135 // Note that the matching is done by string comparison, so this list must not
136 // contain any dynamic strings (e.g. permission for 3 hosts with the host list). 136 // contain any dynamic strings (e.g. permission for 3 hosts with the host list).
137 const int kHighlightedWarnings[] = { 137 const int kHighlightedWarnings[] = {
138 IDS_EXTENSION_PROMPT_WARNING_FULL_ACCESS, 138 IDS_EXTENSION_PROMPT_WARNING_FULL_ACCESS,
139 IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS, 139 IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS,
140 IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS, 140 IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS,
141 IDS_EXTENSION_PROMPT_WARNING_CONTENT_SETTINGS, 141 IDS_EXTENSION_PROMPT_WARNING_CONTENT_SETTINGS,
142 IDS_EXTENSION_PROMPT_WARNING_BROWSING_HISTORY, 142 IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE,
143 IDS_EXTENSION_PROMPT_WARNING_INPUT, 143 IDS_EXTENSION_PROMPT_WARNING_INPUT,
144 IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT, 144 IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT,
145 IDS_EXTENSION_PROMPT_WARNING_TABS, 145 IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ,
146 IDS_EXTENSION_PROMPT_WARNING_DEBUGGER 146 IDS_EXTENSION_PROMPT_WARNING_DEBUGGER
147 }; 147 };
148 148
149 bool IsImportantWarning(const base::string16& message) { 149 bool IsImportantWarning(const base::string16& message) {
150 for (size_t i = 0; i < arraysize(kHighlightedWarnings); ++i) { 150 for (size_t i = 0; i < arraysize(kHighlightedWarnings); ++i) {
151 if (message == l10n_util::GetStringUTF16(kHighlightedWarnings[i])) 151 if (message == l10n_util::GetStringUTF16(kHighlightedWarnings[i]))
152 return true; 152 return true;
153 } 153 }
154 return false; 154 return false;
155 } 155 }
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 const base::string16& message) const { 241 const base::string16& message) const {
242 for (size_t i = 0; i < arraysize(kPermissionExplanations); ++i) { 242 for (size_t i = 0; i < arraysize(kPermissionExplanations); ++i) {
243 if (message == l10n_util::GetStringUTF16( 243 if (message == l10n_util::GetStringUTF16(
244 kPermissionExplanations[i].warning_msg_id)) { 244 kPermissionExplanations[i].warning_msg_id)) {
245 return l10n_util::GetStringUTF16( 245 return l10n_util::GetStringUTF16(
246 kPermissionExplanations[i].extra_explanation_id); 246 kPermissionExplanations[i].extra_explanation_id);
247 } 247 }
248 } 248 }
249 return base::string16(); 249 return base::string16();
250 } 250 }
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/extensions/permissions/chrome_api_permissions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698